Skip to content

add full support for async-trait #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2023
Merged

add full support for async-trait #161

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b13d54a
add full support for async-trait
mellowagain Nov 29, 2023
b34287c
move async trait support from compile fail to pass
mellowagain Nov 30, 2023
4a41924
update changelog
mellowagain Nov 30, 2023
b9e2245
update changelog again
mellowagain Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update changelog again
  • Loading branch information
@mellowagain
mellowagain committed Nov 30, 2023
commit b9e22451c6747158826bb27ff460dcbc356c753c
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ ensure that you match the version that Autometrics uses.**
`otel-push-exporter` is enabled
- Fixed incorrect duration being recorded when using `#[async_trait]` together with `#[autometrics]` (#161)
**Please note that the `#[autometrics]` macro needs to be defined BEFORE `#[async_trait]`.**
- Fixed value of the `result` label being empty when the function is annotated with `#[async_trait]` (#161)

### Autometrics 1.0 compliance

Expand Down