Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try switching match arms
  • Loading branch information
Gerry Agbobada committed May 3, 2023
commit 4621282a515c1ad8bcaa1045cbd650f166862492
6 changes: 1 addition & 5 deletions autometrics-macros/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,10 @@ fn instrument_function(args: &AutometricsArgs, item: ItemFn) -> Result<TokenStre
}
}
} else {
let labels = quote! {
autometrics::result_labels!(&result)
};

quote! {
{
use autometrics::__private::{CALLER, CounterLabels, GetLabels};
let result_labels = #labels;
let result_labels = autometrics::result_labels!(&result);
CounterLabels::new(
#function_name,
module_path!(),
Expand Down
17 changes: 8 additions & 9 deletions autometrics/src/labels.rs
Original file line number Diff line number Diff line change
Expand Up @@ -250,27 +250,27 @@ macro_rules! result_labels {
}
}

match<T: GetLabels, E> &Result<T, E> -> Option<ResultAndReturnTypeLabels> {
match<T, E: GetLabels> &Result<T, E> -> Option<ResultAndReturnTypeLabels> {
match val {
Ok(ok) => Some((
ok.__autometrics_get_labels().unwrap_or(OK_KEY),
OK_KEY,
ok.__autometrics_static_str(),
)),
Err(err) => Some((
ERROR_KEY,
err.__autometrics_get_labels().unwrap_or(ERROR_KEY),
err.__autometrics_static_str(),
)),
}
}

match<T, E: GetLabels> &Result<T, E> -> Option<ResultAndReturnTypeLabels> {
match<T: GetLabels, E> &Result<T, E> -> Option<ResultAndReturnTypeLabels> {
match val {
Ok(ok) => Some((
OK_KEY,
ok.__autometrics_get_labels().unwrap_or(OK_KEY),
ok.__autometrics_static_str(),
)),
Err(err) => Some((
err.__autometrics_get_labels().unwrap_or(ERROR_KEY),
ERROR_KEY,
err.__autometrics_static_str(),
)),
}
Expand All @@ -290,11 +290,10 @@ macro_rules! result_labels {
}

match<T: GetLabels> &T -> Option<ResultAndReturnTypeLabels> {
val.__autometrics_get_labels().map(|label|
(label, val.__autometrics_static_str()))
val.__autometrics_get_labels().map(|label| (label, val.__autometrics_static_str()))
}

match<T> &T -> Option<ResultAndReturnTypeLabels> {
match<T> T -> Option<ResultAndReturnTypeLabels> {
None
}
}
Expand Down