Prometheus-exporter feature shouldn't enable the prometheus crate for producing metrics #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… producing metrics
Contributor
Author
|
It turns out that there was a concurrency bug in how |
Contributor
Author
|
Replaced by #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
prometheus-exporterfeature enables theprometheusfeature, which not only pulls in theprometheusdependency (which we want), but it also overrides the default metrics library used to produce metrics soprometheusis used instead ofopentelemetry.When this mistake is corrected, the tests fail, indicating that there is a bug with how we're producing metrics when using
opentelemetry.