Upgrade substrate fix #1210
Merged
Upgrade substrate fix #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force using the wasmtime everythere in substrate-test-runtime-client.
nazar-pc
reviewed
Mar 2, 2023
Member
nazar-pc
left a comment
nazar-pc
left a comment
There was a problem hiding this comment.
Thanks for taking care of this!
| self, | ||
| ) -> (Client<B>, sc_consensus::LongestChain<B, substrate_test_runtime::Block>) { | ||
| self.build_with_native_executor(None) | ||
| self.build_with_native_executor(Some(new_native_executor())) |
Member
There was a problem hiding this comment.
Do we really want native though? I'd prefer to use compiled WASM instead, especially with native executor going away in the future.
Contributor
Author
There was a problem hiding this comment.
Well, It's actually NativeElseWasmExecutor https://github.com/subspace/subspace/pull/1210/files#diff-49e30e984a0da673301f6d55c117ceb3124cc6d072cfdc35a09d76edf22e16b6L278 which is still the standard right now.
nazar-pc
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the windows failure in #1198
Code contributor checklist: