Update substrate follow-up #2677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
NingLin-P,
rg3l3dr,
shamil-gadelshin and
vedhavyas
as code owners
…nericChainSpec::builder` and work around some bugs
nazar-pc
force-pushed
the
update-substrate-follow-up
branch
from
0757aab to
b99087d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
vedhavyas
previously approved these changes
Apr 11, 2024
NingLin-P
reviewed
Apr 15, 2024
Contributor
NingLin-P
left a comment
NingLin-P
left a comment
There was a problem hiding this comment.
The changes make sense to me, please resolve the conflict.
NingLin-P
previously approved these changes
Apr 15, 2024
Contributor
|
Tests failed due to parsing domain runtime name: |
…ow-up # Conflicts: # crates/subspace-node/src/chain_spec.rs
nazar-pc
force-pushed
the
update-substrate-follow-up
branch
from
61d10f4 to
e2400b5
Compare
Member
Author
|
Had to update workaround since there could be multiple domains now |
vedhavyas
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades many dependencies after #2667 and removes use of deprecated API
GenericChainSpec::from_genesisthat should already be removed upstream by now and will simplify further Substrate upgrades.I did some checks locally, but will appreciate checks whether domains still work fine with these changes. Some hacks were needed due to paritytech/polkadot-sdk#4001
Code contributor checklist: