Increase state sync retries #3222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
approved these changes
Nov 8, 2024
Contributor
|
Perhaps the proposal in polkadot-fellows/RFCs#112 can be considered to improve the state sync performance for the short term. The patch is super simple if we don't take the backward compatibility into account (not sure if it's too late for network breaking changes though), just a few change lines liuchengxu/polkadot-sdk@2556fef, but the improvement is significant. |
Member
Author
|
Yes, I'm following that proposal and already considered patching out fork. We just launched mainnet though, so we'll have to have some sort of compatibility layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wouldn't hurt doing more attempts, but might help some users. Looks like large genesis state makes it difficult for some users to download it an situation will only get worse over time.
Code contributor checklist: