-
Notifications
You must be signed in to change notification settings - Fork 257
Update Substrate #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Substrate #911
Conversation
|
Can you update the CI and install protoc for libp2p? Here is a good action for that: - name: Install Protoc
uses: arduino/setup-protoc@v1 |
9f6ba36 to
f787970
Compare
f787970 to
c40f68f
Compare
|
Should be good for review now |
vedhavyas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
LGTM!
c40f68f to
45fa7fc
Compare
|
Fixed docs compilation (to a degree) and some warnings (that were there before), but now stuck with brson/wasm-opt-rs#114 |
|
UPD: We're simply running out of disk space now on Windows 🤔 |
45fa7fc to
b7ac18b
Compare
|
Added one more patch to Substrate fork (also submitted as paritytech/substrate#12672) that should allow us to decrease disk space usage, especially with growing number of runtimes. Let's see if it helps. |
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I tested the DSN version of the bootstrap node, farmer, and node. All works as expected.
…ccd6821e395f in our fork and ORML's vesting pallet to f4ef99fb108232c4c1fe9ed54d08be3681b77669
…pired by upstream BABE changes
b7ac18b to
b986209
Compare
|
Okay, force-pushed one last time, just added workaround for Windows not deleting files (see last commit mentioned in PR description). Thanks for the patience here everyone! |
# Conflicts: # crates/sp-domains/src/lib.rs # crates/subspace-networking/src/create.rs # domains/client/domain-executor/src/system_bundle_producer.rs # domains/client/relayer/Cargo.toml # domains/client/relayer/src/lib.rs # domains/client/relayer/src/worker.rs # domains/pallets/domain-tracker/src/tests.rs # domains/primitives/domain-tracker/Cargo.toml
|
Conflicts were minor, fixed them and this should be ready to go |
This is a huge PR that updates Substrate. Due to long time since last update there were quite a bit of changes that required many small and medium size tweaks, primarily caused by following:
BlockIdreplaced withBlock::Hashin numerous places (lots of updates)There were some other tweaks upstream that I applied to our codebase as well in commits after the first one that compiles and runs. One interesting side effect was with temporary directories due to Substrate reusing it rather than generating a new one on each invocation, so our execution tests were all competing for the same directory, had to make paths explicit there.
This PR is a mess, but thankfully most of the changes are either in lock file or trivial.
Substrate fork we have was rebased against upstream that contains many of the tweaks we carried, we only have two patches on top of upstream right now, please take a look if you want:
WASM_BUILD_CLEAN_TARGETenvironment variable that cleans up unnecessary wasm build artifactsCode contributor checklist: