Skip to content

Fix noctx linter #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshua-kim wants to merge 3 commits into from
Closed

Fix noctx linter #4163

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6047727
fix noctx linter
joshua-kim Aug 8, 2025
346610b
nit
joshua-kim Oct 3, 2025
cd9bb5d
fix
joshua-kim Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit 
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
  • Loading branch information
@joshua-kim
joshua-kim committed Oct 3, 2025
commit 346610bf4af0d851e3743bb54204d344b03d8154
3 changes: 1 addition & 2 deletions tests/fixture/tmpnet/process_runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,12 @@ func (p *ProcessRuntime) Start(ctx context.Context) error {
return stacktrace.Errorf("writing node flags: %w", err)
}

// All arguments are provided in the flags file.
//
// Ensure process is detached from the parent process so that an error in the
// parent will not affect the child.
cmd := exec.CommandContext(
context.WithoutCancel(ctx),
runtimeConfig.AvalancheGoPath,
// All arguments are provided in the flags file
"--config-file",
p.node.GetFlagsPath(),
) // #nosec G204
Expand Down
Loading