[bootstrapmonitor] Switch from latest to master tag
#4490
Conversation
maru-ava
force-pushed
the
maru/bootstrap-switch-to-master
branch
from
f85810b to
e3a7ac0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the bootstrap monitor to use the master Docker tag instead of latest to ensure bootstrap testing continues to target the most recently published image from the master branch. This change is necessary due to a separate PR (#4469) that will repurpose the latest tag to point to the most recent release rather than the latest master build.
Key Changes:
- Renamed functions and variables from
latesttomasterthroughout the codebase - Updated Docker image tagging logic to use
mastertag for testing - Updated documentation to reflect the tag change
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/fixture/bootstrapmonitor/wait.go | Renamed function calls and variables from latest to master |
| tests/fixture/bootstrapmonitor/init.go | Updated image tag check and function calls from latest to master |
| tests/fixture/bootstrapmonitor/e2e/e2e_test.go | Renamed image variables and build environment variables from latest to master |
| tests/fixture/bootstrapmonitor/common.go | Renamed function and updated comments from latest to master |
| tests/fixture/bootstrapmonitor/bootstrap_test_config.go | Updated comment to reference master tag instead of latest |
| tests/fixture/bootstrapmonitor/README.md | Updated documentation to reference master tag instead of latest |
| scripts/tests.load.kube.kind.sh | Updated image name and build flag to use master tag |
| scripts/build_image.sh | Added new FORCE_TAG_MASTER flag and removed FORCE_TAG_LATEST usage from master branch tagging logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maru-ava
force-pushed
the
maru/bootstrap-switch-to-master
branch
from
e3a7ac0 to
bc0e68c
Compare
A recent PR (#4469) proposes to change the `latest` tag to refer to the image of the most recent release intead of the latest merge to master. This change requires updating the bootstrap monitor to use the `master` tag (already updated on every merge to master) to ensure bootstrap testing continues to target the most recently published image.
maru-ava
force-pushed
the
maru/bootstrap-switch-to-master
branch
from
bc0e68c to
9787998
Compare
maru-ava
force-pushed
the
maru/bootstrap-switch-to-master
branch
from
9787998 to
b9c811f
Compare
| // GetMasterImageDetails retrieves the image details for the avalanchego image with tag `master`. | ||
| func getMasterImageDetails( |
There was a problem hiding this comment.
Pls fix the typo in the doc.string func name to reference getMasterImageDetails instead of GetMasterImageDetails, ensuring consistency with the function's declaration. Without this adjustment, a godoc reader might mistakenly expect bootstrapmonitor.GetMasterImageDetails(...) to be callable.
Other than the typo above, the PR LGTM.
Why this should be merged
A recent PR (#4469) proposes to change the
latesttag to refer to the image of the most recent release intead of the latest merge to master. This change requires updating the bootstrap monitor to use themastertag (already updated on every merge to master) to ensure bootstrap testing continues to target the most recently published image.How this was tested
CI
Need to be documented in RELEASES.md?
N/A