chore: nits

tests/reexecute/blockexport/main.go

@@ -39,7 +39,14 @@ func main() {
 	defer tc.RecoverAndExit()
 
 	r := require.New(tc)
-	blockChan, err := reexecute.CreateBlockChanFromLevelDB(blockDirSrcArg, startBlockArg, endBlockArg, chanSizeArg, tc.DeferCleanup)
+	blockChan, err := reexecute.CreateBlockChanFromLevelDB(
+		tc,
+		blockDirSrcArg,
+		startBlockArg,
+		endBlockArg,
+		chanSizeArg,
+		tc.DeferCleanup,
+	)
 	r.NoError(err)
 
 	db, err := leveldb.New(blockDirDstArg, nil, logging.NoLog{}, prometheus.NewRegistry())

tests/reexecute/c/vm_reexecute_test.go

@@ -225,7 +225,7 @@ func benchmarkReexecuteRange(
 		zap.Int("chan-size", chanSize),
 	)
 
-	blockChan, err := reexecute.CreateBlockChanFromLevelDB(blockDir, startBlock, endBlock, chanSize, b.Cleanup)
+	blockChan, err := reexecute.CreateBlockChanFromLevelDB(b, blockDir, startBlock, endBlock, chanSize, b.Cleanup)
 	r.NoError(err)
 
 	dbLogger := tests.NewDefaultLogger("db")

tests/reexecute/db.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 
 	"github.com/prometheus/client_golang/prometheus"
+	"github.com/stretchr/testify/require"
 
 	"github.com/ava-labs/avalanchego/database"
 	"github.com/ava-labs/avalanchego/database/leveldb"
@@ -27,15 +28,16 @@ type BlockResult struct {
 // Blocks are read sequentially and sent to the returned channel as BlockResult values.
 //
 // Any validation errors or iteration errors are sent as BlockResult with Err set, then the channel is closed.
-func CreateBlockChanFromLevelDB(sourceDir string, startBlock, endBlock uint64, chanSize int, cleanup func(func())) (<-chan BlockResult, error) {
+func CreateBlockChanFromLevelDB(t require.TestingT, sourceDir string, startBlock, endBlock uint64, chanSize int, cleanup func(func())) (<-chan BlockResult, error) {
+	r := require.New(t)
 	ch := make(chan BlockResult, chanSize)
 
 	db, err := leveldb.New(sourceDir, nil, logging.NoLog{}, prometheus.NewRegistry())
 	if err != nil {
 		return nil, fmt.Errorf("failed to create leveldb database from %q: %w", sourceDir, err)
 	}
 	cleanup(func() {
-		db.Close()
+		r.NoError(db.Close())
 	})
 
 	go func() {