Skip to content
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e096dc1
refactor: block export
RodrigoVillar Dec 2, 2025
fa99ce5
chore: nits
RodrigoVillar Dec 3, 2025
a433a81
chore(reexecute/c): remove go bench from benchmark
RodrigoVillar Dec 2, 2025
c1203b1
chore: remove go bench in workflow
RodrigoVillar Dec 2, 2025
1935adf
chore: reduce diff
RodrigoVillar Dec 2, 2025
b508826
chore: use test context logger
RodrigoVillar Dec 4, 2025
953a76e
chore: clean up benchmarkTool
RodrigoVillar Dec 4, 2025
e6481ab
docs: benchmarking types
RodrigoVillar Dec 4, 2025
89abbde
refactor: use tc wherever convenient
RodrigoVillar Dec 4, 2025
5f55711
refactor: clean up result logging
RodrigoVillar Dec 4, 2025
afac7bc
fix: append unit to base name
RodrigoVillar Dec 4, 2025
a817e73
chore: remove unnecessary log
RodrigoVillar Dec 4, 2025
d0b95de
Merge branch 'master' into rodrigo/custom-benchmarks
RodrigoVillar Dec 9, 2025
828abe3
chore: nit
RodrigoVillar Dec 9, 2025
01f0663
chore: add back require
RodrigoVillar Dec 9, 2025
18b884d
chore: txt => json
RodrigoVillar Dec 9, 2025
d4639ff
docs: remove stale ref
RodrigoVillar Dec 9, 2025
718bc52
docs: nit
RodrigoVillar Dec 9, 2025
b26e8c4
chore: improve logResults()
RodrigoVillar Dec 9, 2025
3588978
chore: address PR review
RodrigoVillar Dec 9, 2025
9e7f54f
Merge branch 'master' into rodrigo/custom-benchmarks
RodrigoVillar Dec 10, 2025
bc78644
chore(reexecute/c): add back scraping of multiple metrics
RodrigoVillar Dec 10, 2025
29da042
Merge branch 'master' into rodrigo/add-back-multiple-metrics
RodrigoVillar Dec 16, 2025
7250778
chore: nit
RodrigoVillar Dec 16, 2025
43f9633
chore: nsPerMs => nanosecondsPerMillisecond
RodrigoVillar Dec 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: append unit to base name
  • Loading branch information
RodrigoVillar committed Dec 4, 2025
commit afac7bcb99e325d26eace44ecbbce6e5bd370281
9 changes: 5 additions & 4 deletions tests/reexecute/c/vm_reexecute.go
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,8 @@ type benchmarkTool struct {
}

// newBenchmarkTool creates a new benchmarkTool instance with the given name.
// The name is used to identify all results collected by this tool.
// The name is used as the base name for all results collected by this tool.
// When results are added, the unit is appended to this base name.
func newBenchmarkTool(name string) *benchmarkTool {
return &benchmarkTool{
name: name,
Expand All @@ -606,11 +607,11 @@ func newBenchmarkTool(name string) *benchmarkTool {
}

// addResult adds a new benchmark result with the given value and unit.
// All results added share the same benchmark name set during tool creation.
// This is analogous to calling `b.ReportMetric()`.
// The result name is constructed by appending the unit to the benchmark name
// Calling `addResult` is analogous to calling `b.ReportMetric()`.
func (b *benchmarkTool) addResult(value float64, unit string) {
result := benchmarkResult{
Name: b.name,
Name: fmt.Sprintf("%s - %s", b.name, unit),
Value: strconv.FormatFloat(value, 'f', -1, 64),
Unit: unit,
}
Expand Down