No delay after final retry on max attempts

[StounhandJ]

This MR addresses an issue where a delay is still applied after the final attempt, even when the maximum number of attempts for a specific error type has been reached.

Problem:
When using the retry.AttemptsForError() option to define a custom attempt limit for a specific error type, the retry logic still applies the configured delay after the final permitted attempt for that error. This results in unnecessary wait time and inconsistent behavior.

Steps to Reproduce:

pacakge main

var count uint64 = 0
var currentTime = time.Now()

type TestError struct {
}

func (TestError) Error() string {
	return ""
}

func action() error {
	count += 1
	fmt.Printf("Attempts: %v; Time: %v\n", count, time.Since(currentTime).Round(time.Second))
	currentTime = time.Now()

	return TestError{}
}

func main() {
	_ = retry.Do(action,
		retry.Attempts(3),
		retry.Delay(2*time.Second),
		retry.DelayType(retry.FixedDelay),
		retry.AttemptsForError(2, TestError{}),
		retry.LastErrorOnly(true),
		retry.Context(context.Background()))

	fmt.Printf("End Time: %v\n", time.Since(currentTime).Round(time.Second))
}

Observed Output:

Attempts: 1; Time: 0s
Attempts: 2; Time: 2s
End Time: 2s

Expected Output:

Attempts: 1; Time: 0s
Attempts: 2; Time: 2s
End Time: 0s

[JaSei]

Thanks for this PR. I apologize for the delayed response. To be honest, I switched jobs a while back and moved to a completely different tech stack, so I wasn't able to give this project the attention it deserved. I'm catching up now, though, and I'm happy to merge this. Thanks again for your work!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (cbf4dbf) to head (e330bce).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #129       +/-   ##
=========================================
- Coverage   90.86%      0   -90.87%     
=========================================
  Files           2      0        -2     
  Lines         230      0      -230     
=========================================
- Hits          209      0      -209     
+ Misses         17      0       -17     
+ Partials        4      0        -4     

Flag	Coverage Δ
unittest	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[StounhandJ]

Thanks for this PR. I apologize for the delayed response. To be honest, I switched jobs a while back and moved to a completely different tech stack, so I wasn't able to give this project the attention it deserved. I'm catching up now, though, and I'm happy to merge this. Thanks again for your work!

I am very happy for you with your new job. I hope I can still help with this or another library.