Skip to content

Conversation

@dougtoppin
Copy link
Contributor

@dougtoppin dougtoppin commented Feb 7, 2023

Issue #, if available:

Description of changes:
PRs contained within this release:

Checklist

  • 👋 I have added unit tests for all code changes.
  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dougtoppin dougtoppin marked this pull request as ready for review February 7, 2023 21:51
Doug Toppin and others added 3 commits February 7, 2023 17:15
…tack deployments (#438)

* Add stack name to service catalog application

This allows multiple stack deployments in the same account, region

* Update cdk snapshot

* Add changelog entry

* Prepend AppRegistry application name with static name

Stack name is used in naming AppRegistry application and attribute group; which must not begin with aws.
The change adds support for stack names starting with aws-*
Copy link
Member

@gsingh04 gsingh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. one nit, would like to see commit description explain why the change was made.

@gsingh04 gsingh04 merged commit 4e13895 into main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants