add support for CloudFront logging to s3 object ownership changes #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearde
previously approved these changes
Apr 14, 2023
G-Lenz
previously approved these changes
Apr 14, 2023
update xml2js version, add changelog entry run prettier, update snapshot, update versions update changelog with s3 change reason
dougtoppin
force-pushed
the
fix/cloudfronts3logging
branch
from
aba3fd4 to
188626a
Compare
G-Lenz
approved these changes
Apr 14, 2023
schana
approved these changes
Apr 17, 2023
gsingh04
reviewed
Apr 17, 2023
source/constructs/lib/common-resources/custom-resources/custom-resource-construct.ts
Show resolved
Hide resolved
thisismana
pushed a commit
to thisismana/serverless-image-handler
that referenced
this pull request
Oct 17, 2025
…ws-solutions#464) Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4 to 5. - [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases) - [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md) - [Commits](aws-actions/configure-aws-credentials@v4...v5) --- updated-dependencies: - dependency-name: aws-actions/configure-aws-credentials dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A recent change was made regarding the default S3 bucket and object ownership configuration. This impacted the CloudFront S3 Logging bucket that is created by the custom resource Lambda which caused the deployment to fail.
Configuration changes associated with the bucket creation were necessary.
The announcement for the Amazon S3 change can be found at https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/
Changes
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.