deleted #571
Closed
deleted #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reimplemented logger and logger unit test suite to not interfere with global side effects of the other giant monolithic test suits by awslabs * Refactored logger calls to provide usefull information and document what the provided data is about * Refactored logger calls in image request module to provide usefull information and document what the provided data is about * Refactored logger calls in image handler module to provide usefull information and document what the provided data is about
also pushing all docker tags.
* Implemented logging with the right JSON format with exception logging and additional info about the cloudwatch event. * Reverted pretest script
[skip ci]
* field names * log levels: removed "log" * removed logging of binary image data * some more cache headers: 4xx will cache for a while, 5xx will not
[skip ci]
* bumped to latest, merged some updates from upstream * - adapted for new key pattern `/$YEAR/$MONTH/$MEDIA_ID/` ignoring file name and always using `image.$EXT` - roundCrops - improved local development by fixing invoke.js and making the logger env-aware * - adapted for new key pattern `/$YEAR/$MONTH/$MEDIA_ID/` ignoring file name and always using `image.$EXT` - roundCrops - improved local development by fixing invoke.js and making the logger env-aware
* migrate image-handler from javascript to typescript and update Readme * feat: variant deployment * feat: prod deployment * fixed test * fix: build command * bump lambda to nodejs 20 runtime --------- Co-authored-by: Matthias Naber <[email protected]>
* cleanup/typings * cleanup/typings * removed obsolete and redundant code - default mapping - custom mapping - recognition
* chore: bumped Lambda modules * aligned Makefile with other multi-func projects * bumped gh actions
[skip ci]
Also: - formatting with prettier - bumped some dependencies
* pulled remote solution - removed recognition - removed dynamic buckets - removed secretsmanager - remove signed URLs * updated gh action - removed old thumbhash - using arm runner * finalizing touches * pr feedback (merging package.json) * - added proper logging - fixed tests - handle expired images * fine-tuned logging * added editorconfig * added `error` to logged fields * added `immutable` to cache control * go live preparations
…on (#412) - added `/filters:thumbhash()/` to trigger this feature
prior to this fix this was a `http/5xx`. now this should yield in a `http/400 bad request`.
|
I created a wrong pr. Would be great if you can delete it. Sorry for that mistake... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.