Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jun 3, 2025

Just noticed some missed opportunities in the error handling for the CCAPI provider.

This only has limited end-user impact:

  • instead of error: cause it's now error\ncause
  • Some not enough results found error messages now include the expectation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 3, 2025 16:46
@mrgrain mrgrain force-pushed the mrgrain/fix/toolkit-lib/error-handling branch from c955fba to e5d0e53 Compare June 3, 2025 16:47
@mrgrain mrgrain force-pushed the mrgrain/fix/toolkit-lib/error-handling branch from e5d0e53 to 9193928 Compare June 3, 2025 16:47
@mrgrain mrgrain temporarily deployed to integ-approval June 3, 2025 16:47 — with GitHub Actions Inactive
@mrgrain mrgrain changed the title fix(toolkit-lib): improve error handling chore(toolkit-lib): improve CCAPI context provider error handling Jun 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (49699d8) to head (fdc562e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   79.61%   79.00%   -0.61%     
==========================================
  Files          47       47              
  Lines        7083     7083              
  Branches      798      791       -7     
==========================================
- Hits         5639     5596      -43     
- Misses       1423     1468      +45     
+ Partials       21       19       -2     
Flag Coverage Δ
suite.unit 79.00% <ø> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 666c9cc Jun 4, 2025
21 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/toolkit-lib/error-handling branch June 4, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants