generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 56
chore(toolkit-lib): improve CCAPI context provider error handling #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aws-cdk-automation
merged 2 commits into
main
from
mrgrain/fix/toolkit-lib/error-handling
Jun 4, 2025
Merged
chore(toolkit-lib): improve CCAPI context provider error handling #570
aws-cdk-automation
merged 2 commits into
main
from
mrgrain/fix/toolkit-lib/error-handling
Jun 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c955fba to
e5d0e53
Compare
e5d0e53 to
9193928
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 79.61% 79.00% -0.61%
==========================================
Files 47 47
Lines 7083 7083
Branches 798 791 -7
==========================================
- Hits 5639 5596 -43
- Misses 1423 1468 +45
+ Partials 21 19 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iliapolo
requested changes
Jun 4, 2025
packages/@aws-cdk/toolkit-lib/test/context-providers/cc-api-provider.test.ts
Outdated
Show resolved
Hide resolved
iliapolo
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed some missed opportunities in the error handling for the CCAPI provider.
This only has limited end-user impact:
error: causeit's nowerror\ncauseBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license