Skip to content

Conversation

@kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Jun 3, 2025

CliAction type feels slightly off as it should be CliAction and not ToolkitAction. This makes the default make sense. Either way, the internal property of CliIoHost is typed to CliAction.

In practice this probably doesn't matter because I don't think we are initializing CliIoHost with anything but none.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 3, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 3, 2025 20:55
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.14%. Comparing base (554d2c9) to head (5063acc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   79.00%   79.14%   +0.13%     
==========================================
  Files          47       47              
  Lines        7083     7086       +3     
  Branches      791      796       +5     
==========================================
+ Hits         5596     5608      +12     
+ Misses       1468     1459       -9     
  Partials       19       19              
Flag Coverage Δ
suite.unit 79.14% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaizencc kaizencc temporarily deployed to integ-approval June 4, 2025 14:27 — with GitHub Actions Inactive
@kaizencc kaizencc changed the title chore(toolkit): expose cli action chore(toolkit): type currentAction as CliAction Jun 4, 2025
@kaizencc kaizencc requested a review from mrgrain June 4, 2025 14:27
@mrgrain mrgrain changed the title chore(toolkit): type currentAction as CliAction chore(cli): type currentAction as CliAction Jun 4, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit e629e30 Jun 4, 2025
29 of 31 checks passed
@aws-cdk-automation aws-cdk-automation deleted the conroy/cliaction branch June 4, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants