chore(cli): telemetry sink #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
|
exempt integ test because this PR only adds new classes, it does not use them anywhere besides unit tests |
kaizencc
commented
Jul 2, 2025
kaizencc
commented
Jul 2, 2025
| fs.appendFileSync(this.logFilePath, output); | ||
| } catch (e: any) { | ||
| // Never throw errors, just log them via ioHost | ||
| await this.ioHelper.defaults.warn(`Failed to add telemetry event: ${e.message}`); |
There was a problem hiding this comment.
test that this sends a trace msg but does not throw
kaizencc
commented
Jul 2, 2025
kaizencc
commented
Jul 2, 2025
kaizencc
commented
Jul 2, 2025
iliapolo
approved these changes
Jul 3, 2025
| */ | ||
| export class EndpointTelemetrySink implements ITelemetrySink { | ||
| private events: TelemetrySchema[] = []; | ||
| private endpoint: UrlWithStringQuery; |
There was a problem hiding this comment.
Should accept a string and parse internally. It would avoid exposing nodejs types in the props interface. Also - external callers are not the ones who want to parse, its this class that needs it, so it should do it.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
Follow up to #585 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a generic telemetry sink to the cli. it is tested but not used anywhere.
There are 3 base types of telemetry sinks:
FileSink-> gathers events and writes them to a fileIoHostSink-> gathers events and sends them to the IoHost (for writing to stdout/err)EndpointSink-> gathers events and sends them to an external endpoint, batching at intervals of 30 seconds.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license