Skip to content

Conversation

@iankhou
Copy link
Contributor

@iankhou iankhou commented Jun 11, 2025

Fixes #597

10.0.2 has been identified to contain regressions. Pin to 10.0.1.

ref: isaacs/minimatch#257


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iankhou iankhou self-assigned this Jun 11, 2025
@iankhou iankhou temporarily deployed to integ-approval June 11, 2025 21:26 — with GitHub Actions Inactive
@iankhou iankhou added the pr/exempt-integ-test Skips the integ test steps if set. label Jun 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 11, 2025 21:27
@github-actions github-actions bot added the p2 label Jun 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (63dc804) to head (478975c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   79.06%   79.01%   -0.06%     
==========================================
  Files          46       46              
  Lines        7085     7085              
  Branches      792      791       -1     
==========================================
- Hits         5602     5598       -4     
- Misses       1464     1468       +4     
  Partials       19       19              
Flag Coverage Δ
suite.unit 79.01% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou disabled auto-merge June 11, 2025 22:04
@iankhou iankhou enabled auto-merge June 11, 2025 22:04
@iankhou iankhou added p1 and removed p2 labels Jun 11, 2025
@iankhou iankhou disabled auto-merge June 11, 2025 22:10
@iankhou iankhou enabled auto-merge June 11, 2025 22:10
@iankhou iankhou closed this Jun 11, 2025
auto-merge was automatically disabled June 11, 2025 22:10

Pull request was closed

@iankhou iankhou reopened this Jun 11, 2025
@iankhou iankhou added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit cb71364 Jun 11, 2025
57 of 59 checks passed
@iankhou iankhou deleted the iankhou-minimatch-patch branch June 11, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error [ERR_REQUIRE_ESM]: require() of ES Module /usr/local/lib/node_modules/cdk-assets/node_modules/brace-expansion/index.js

3 participants