Skip to content

Conversation

iankhou
Copy link
Contributor

@iankhou iankhou commented Jun 12, 2025

Fixes #597


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iankhou iankhou self-assigned this Jun 12, 2025
@github-actions github-actions bot added the p1 label Jun 12, 2025
@iankhou iankhou added the pr/exempt-integ-test Skips the integ test steps if set. label Jun 12, 2025
@iankhou iankhou closed this Jun 12, 2025
auto-merge was automatically disabled June 12, 2025 00:23

Pull request was closed

@iankhou iankhou reopened this Jun 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 12, 2025 00:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (cb71364) to head (fc12735).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   79.01%   79.59%   +0.57%     
==========================================
  Files          46       46              
  Lines        7085     7085              
  Branches      790      793       +3     
==========================================
+ Hits         5598     5639      +41     
+ Misses       1468     1427      -41     
  Partials       19       19              
Flag Coverage Δ
suite.unit 79.59% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iankhou iankhou enabled auto-merge June 12, 2025 00:46
@iankhou iankhou added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit 65e802f Jun 12, 2025
11 checks passed
@iankhou iankhou deleted the iankhou-assets-minimatch branch June 12, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error [ERR_REQUIRE_ESM]: require() of ES Module /usr/local/lib/node_modules/cdk-assets/node_modules/brace-expansion/index.js

3 participants