Skip to content

fix: "Invalid Assembly Manifest" when used with CLI 2.1017.0 and 2.1018.0 #34880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

fix: "Invalid Assembly Manifest" when used with CLI 2.1017.0 and 2.1018.0 #34880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "feat: report feature flag configuration into Cloud Assembly (#… 
…34798)"

This reverts commit 76af7dc.
  • Loading branch information
@rix0rrr
rix0rrr authored Jul 2, 2025
commit 82579ffaca44ec9bb43b4286b13d174055f82be2
39 changes: 0 additions & 39 deletions packages/aws-cdk-lib/core/lib/private/feature-flag-report.ts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/aws-cdk-lib/core/lib/private/synthesis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { Stack } from '../stack';
import { ISynthesisSession } from '../stack-synthesizers/types';
import { Stage, StageSynthesisOptions } from '../stage';
import { IPolicyValidationPluginBeta1 } from '../validation';
import { generateFeatureFlagReport } from './feature-flag-report';
import { ConstructTree } from '../validation/private/construct-tree';
import { PolicyValidationReportFormatter, NamedValidationPluginReport } from '../validation/private/report';

Expand Down Expand Up @@ -65,8 +64,6 @@ export function synthesize(root: IConstruct, options: SynthesisOptions = { }): c
// stacks to add themselves to the synthesized cloud assembly.
synthesizeTree(root, builder, options.validateOnSynthesis);

generateFeatureFlagReport(builder, root);

const assembly = builder.buildAssembly();

invokeValidationPlugins(root, builder.outdir, assembly);
Expand Down
51 changes: 0 additions & 51 deletions packages/aws-cdk-lib/core/test/feature-flag-report.test.ts
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions packages/aws-cdk-lib/core/test/stage.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ describe('stage', () => {
const rootAssembly = app.synth();

// THEN
expect(rootAssembly.manifest.artifacts).toMatchObject({
expect(rootAssembly.manifest.artifacts).toEqual({
'assembly-StageLevel1': {
type: 'cdk:cloud-assembly',
properties: {
Expand All @@ -263,7 +263,7 @@ describe('stage', () => {
});

const assemblyLevel1 = rootAssembly.getNestedAssembly('assembly-StageLevel1');
expect(assemblyLevel1.manifest.artifacts).toMatchObject({
expect(assemblyLevel1.manifest.artifacts).toEqual({
'assembly-StageLevel1-StageLevel2': {
type: 'cdk:cloud-assembly',
properties: {
Expand All @@ -274,7 +274,7 @@ describe('stage', () => {
});

const assemblyLevel2 = assemblyLevel1.getNestedAssembly('assembly-StageLevel1-StageLevel2');
expect(assemblyLevel2.manifest.artifacts).toMatchObject({
expect(assemblyLevel2.manifest.artifacts).toEqual({
'assembly-StageLevel1-StageLevel2-StageLevel3': {
type: 'cdk:cloud-assembly',
properties: {
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/core/test/synthesis.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('synthesis', () => {
// THEN
expect(app.synth()).toEqual(session); // same session if we synth() again
expect(list(session.directory)).toEqual(['cdk.out', 'manifest.json', 'tree.json']);
expect(readJson(session.directory, 'manifest.json').artifacts).toMatchObject({
expect(readJson(session.directory, 'manifest.json').artifacts).toEqual({
Tree: {
type: 'cdk:tree',
properties: { file: 'tree.json' },
Expand Down
Loading