Skip to content

Use ssl context wrap socket in Python3.12+ #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bretambrose merged 8 commits into from
Feb 14, 2024
Merged

Use ssl context wrap socket in Python3.12+ #338

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
47b72d8
Use ssl context wrap socket in Python3.12+
Feb 13, 2024
14ae742
What version of python are we using?
Feb 13, 2024
c090dcf
Another removed API
Feb 13, 2024
8f94bc5
Use a workaround to install 2.7; update GG discovery with SSL context…
Feb 13, 2024
ba91f5a
Not allowed to do that apparently
Feb 13, 2024
e3ca674
Remove 3.5 and guard other call to match_hostname
Feb 13, 2024
c9a756e
Remove redundant test modes
Feb 13, 2024
fa8c56c
Explanatory comment
Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Explanatory comment
  • Loading branch information
Bret Ambrose committed Feb 13, 2024
commit fa8c56ca2f25d914da7303ac3c6e79871831355e
1 change: 1 addition & 0 deletions AWSIoTPythonSDK/core/greengrass/discovery/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ def _create_ssl_connection(self, sock):
if sys.version_info[0] < 3 or (sys.version_info[0] == 3 and sys.version_info[1] < 2):
self._tls_match_hostname(ssl_sock)
elif sys.version_info[0] == 3 and sys.version_info[1] < 7:
# host name verification is handled internally in Python3.7+
ssl.match_hostname(ssl_sock.getpeercert(), self._host)

return ssl_sock
Expand Down