Skip to content

Conversation

@vietle-aws
Copy link
Contributor

@vietle-aws vietle-aws commented Oct 29, 2022

Commit summary:

feat: add content security policy reccomendations to requests without csp

Description of changes:

  • Adding "frame-ancestors 'self'; report-uri /jupyter/default/api/security/csp-report; default-src 'none'; upgrade-insecure-requests; base-uri 'none'" to content security policy
  • Upgrading to 0.3.5

Why:

  • These are security enhancements for aws-jupyter-proxy client/server interactions
  • upgrade-insecure-requests; Replace insecure traffic (served over HTTP) with secure traffic
  • base-uri 'none'; Restricts the URLs which can be used in a document's element

Verification:

pip uninstall aws_jupyter_proxy -y
pip install aws_jupyter_proxy-0.3.5-py3-none-any.whl
nohup supervisorctl -c /etc/supervisor/conf.d/supervisord.conf restart jupyterlabserver > /dev/null 2>&1 &
  • Use pip list to verify aws_jupyter_proxy-0.3.5 is installed
  • Make a network call through Axis without Content-Security-Policy header specified and the call will have a content security policy specified when returned

@pilgd-aws
Copy link

Reviewed and approved. LGTM

@ZhangHan ZhangHan merged commit ac3fafc into aws:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants