fix: missing Auth header returns 400 Bad Request #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@vietle-aws @danpilgrim-aws |
Author
|
@larrygao001 @declanvk please take a look |
Contributor
|
LGTM |
Contributor
|
I reviewed the previous PR associated here. It recommended logging the missing header in case of exception. Can you please incorporate the comments from previous PR? |
aws-khatria
reviewed
Mar 17, 2023
aws_jupyter_proxy/awsproxy.py
Outdated
| auth_header_parts[1].split("=")[1].split("/") | ||
| ) | ||
| except (KeyError, IndexError): | ||
| raise HTTPError(400, message=f"Bad Request") |
Contributor
There was a problem hiding this comment.
Is "Bad Request" sufficient? Does security guideline allow you to put some specific message, like, "Malformed Authorization header"?
aws-khatria
reviewed
Mar 17, 2023
|
|
||
| @pytest.mark.asyncio | ||
| @patch("os.getenv") | ||
| async def test_missing_authorization_header(mock_getenv, mock_session): |
Contributor
There was a problem hiding this comment.
How about a test case for malformed authorization header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit summary:
fix: missing Authorization header returns 400 Bad Request
Description of changes:
KeyErrorandIndexErrorwhen building auth headers, and return a400 Bad Request.Why:
Currently, if an upstream request is missing an
Authorizationheader, a Python stack trace is returned in the response body. This was flagged as a potential security vulnerability. Similar to the issue fixed in #26We now catch
KeyErrorandIndexErrorwhen building upstream request auth headers. We don't expect customers to malform a request, so we deliberately return a vague error message.Verification:
python -m build.pip list.aws_jupyter_proxy, making sure that anAuthorizationheader is missing.400 Bad Requestis returned.