Skip to content

Conversation

@kiwaa
Copy link

@kiwaa kiwaa commented Oct 18, 2024

Updated AWSSDK.Core dependency

Description

Motivation and Context

Version of AWSSDK.Core that is used currently has credentials preempt expiry set to 5 min, while kafka credentials are signed for 15 min. Updated version has all preempt expiry set to 15 min, which matches what is used in this library

It should fix #16

Testing

No more errors from Kafka client every hour (at the end of WebIdentity credentials)

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@kiwaa kiwaa requested a review from a team as a code owner October 18, 2024 08:00
@toini
Copy link

toini commented Oct 23, 2024

We are also seeing Kafka authentication errors after a consumer has been first running fine for a while. It could be the same issue. Could this be merged @sankalpbhatia?

@alexp-sportsbet
Copy link

We're also seeing the same behavior using IAM auth where after 6 hours, things start failing to authenticate until the ECS task fails it's health checks and is restarted.

Reading around - I suspect the updated package in this PR includes the changes that are required to resolve the issue. Adding my vote to getting this merged in to (hopefully) resolve this issue as well 😁

@agarwal1510 agarwal1510 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into aws:main with commit f21acf3 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Role credentials rotation on an ECS task are not handled properly

4 participants