Skip to content

NTHv2 core functionality #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 14, 2022
Merged

NTHv2 core functionality #612

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ac0ce04
core functionality
cjerad Apr 1, 2022
68b973e
fix capitalization
cjerad Apr 4, 2022
2beddc7
add more ways to specify AWS region
cjerad Apr 4, 2022
c4ee5fb
tidy up interface organization
cjerad Apr 4, 2022
0407de6
remove SQS request params from Terminator spec
cjerad Apr 5, 2022
69a0544
update copyright attribution
cjerad Apr 6, 2022
17c2ad0
remove boilerplate comment
cjerad Apr 6, 2022
d217816
expand "Addr" to "Address"
cjerad Apr 6, 2022
87dccd7
fix capitalization
cjerad Apr 6, 2022
6a7b44b
rename event files
cjerad Apr 7, 2022
ab10afa
add more logging for parsing failures
cjerad Apr 7, 2022
186caec
dedup lifecycle action completion code
cjerad Apr 7, 2022
ef556fc
add more test cases
cjerad Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more logging for parsing failures
  • Loading branch information
@cjerad
cjerad committed Apr 7, 2022
commit ab10afa0b5225174d0fffa901b9ce0b42caaffcf
5 changes: 4 additions & 1 deletion src/pkg/event/aggregatedparser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func (p AggregatedParser) Parse(ctx context.Context, str string) terminator.Even
ctx = logging.WithLogger(ctx, logging.FromContext(ctx).Named("event.parser"))

if str == "" {
logging.FromContext(ctx).Warn("nothing to parse")
return noop{}
}

Expand All @@ -49,11 +50,13 @@ func (p AggregatedParser) Parse(ctx context.Context, str string) terminator.Even
}
}

logging.FromContext(ctx).Error("failed to parse")

md := AWSMetadata{}
if err := json.Unmarshal([]byte(str), &md); err != nil {
logging.FromContext(ctx).
With("error", err).
Error("failed to parse SQS message metadata")
Error("failed to unmarshal message metadata")
return noop{}
}
return noop(md)
Expand Down