Skip to content

add make target explore-test-coverage #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2022
Merged

add make target explore-test-coverage #646

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4be605
add explore-test-coverage make target
cjerad May 17, 2022
b6aa8f6
update test workflow to install Make 4.3
cjerad May 18, 2022
25f2bf8
remove grouped targets
cjerad May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ jobs:
~/go/bin/
key: gocache

- name: Upgrade Make
run: |
sudo apt-get update
wget -c http://archive.ubuntu.com/ubuntu/pool/main/m/make-dfsg/make_4.3-4ubuntu1_amd64.deb
sudo apt-get install ./make_4.3-4ubuntu1_amd64.deb

- name: make test
run: make test
working-directory: ./src
12 changes: 11 additions & 1 deletion src/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# The "grouped targets" feature requires Make 4.3.
ifneq (4.3,$(firstword $(sort $(or $(MAKE_VERSION),00-unknown) 4.3)))
$(error using make version $(MAKE_VERSION), please use version 4.3 or newer)
endif

PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
CONTROLLER_GEN = $(PROJECT_DIR)/bin/controller-gen
KO = $(PROJECT_DIR)/bin/ko
Expand All @@ -15,6 +20,7 @@ KODATA = \
cmd/controller/kodata/refs \
cmd/webhook/kodata/HEAD \
cmd/webhook/kodata/refs
CODECOVERAGE_OUT = $(PROJECT_DIR)/coverprofile.out

# Image URL to use all building/pushing image targets
IMG ?= controller:latest
Expand Down Expand Up @@ -66,10 +72,14 @@ verify: ## Run go fmt and go vet against code.
go vet $(PROJECT_DIR)/...

.PHONY: test
test: $(GINKGO) ## Run tests.
test $(CODECOVERAGE_OUT) &: $(GINKGO) ## Run tests.
go vet $(PROJECT_DIR)/...
$(GINKGO) run $(GINKGO_BASE_OPTS) $(GINKGO_OPTS) $(PROJECT_DIR)/test/

.PHONY: explore-test-coverage
explore-test-coverage: $(CODECOVERAGE_OUT) ## Display test coverage report in default web browser.
go tool cover -html=$<

##@ Build

.PHONY: run
Expand Down