Skip to content

Support passing ClientConfiguration to web identity credentials provider. #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support passing ClientConfiguration to web identity credentials provider. #3116

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37c8c1d
Support passing `ClientConfiguration` to web identity credentials pro…
teo-tsirpanis Sep 19, 2024
ad8df6a
Use the region specified in the client config.
teo-tsirpanis Sep 19, 2024
9fcd760
Construct retryable errors vector in-place.
teo-tsirpanis Oct 10, 2024
20bd62f
Address PR feedback.
teo-tsirpanis Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Construct retryable errors vector in-place.
  • Loading branch information
@teo-tsirpanis
teo-tsirpanis committed Oct 10, 2024
commit 9fcd76022ed96e5bb3b849606010edfc4dd06784
6 changes: 2 additions & 4 deletions src/aws-cpp-sdk-core/source/auth/STSCredentialsProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,9 @@ STSAssumeRoleWebIdentityCredentialsProvider::STSAssumeRoleWebIdentityCredentials
config.scheme = Aws::Http::Scheme::HTTPS;

if (config.retryStrategy == nullptr) {
Aws::Vector<Aws::String> retryableErrors;
retryableErrors.push_back("IDPCommunicationError");
retryableErrors.push_back("InvalidIdentityToken");
Aws::Vector<Aws::String> retryableErrors{ "IDPCommunicationError", "InvalidIdentityToken" };

config.retryStrategy = Aws::MakeShared<SpecifiedRetryableErrorsRetryStrategy>(STS_ASSUME_ROLE_WEB_IDENTITY_LOG_TAG, retryableErrors, 3/*maxRetries*/);
config.retryStrategy = Aws::MakeShared<SpecifiedRetryableErrorsRetryStrategy>(STS_ASSUME_ROLE_WEB_IDENTITY_LOG_TAG, std::move(retryableErrors), 3/*maxRetries*/);
}

m_client = Aws::MakeUnique<Aws::Internal::STSCredentialsClient>(STS_ASSUME_ROLE_WEB_IDENTITY_LOG_TAG, config);
Expand Down
Loading