PHP 8.0, 8.1, PHPUnit 9 support #2332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27pchrisl
commented
Oct 11, 2021
| colors="true"> | ||
|
|
||
| <php> | ||
| <!-- Specify the path to your CloudFront private key --> |
Contributor
Author
There was a problem hiding this comment.
This was removed in favour of a change to the suite that enables this to run without any configuration
27pchrisl
commented
Oct 11, 2021
| public static function fromEpoch($unixTimestamp) | ||
| { | ||
| return new self(gmdate('c', $unixTimestamp)); | ||
| if (!is_numeric($unixTimestamp)) { |
27pchrisl
commented
Oct 11, 2021
| @@ -1,65 +1,64 @@ | |||
| <?php | |||
Contributor
Author
There was a problem hiding this comment.
Changes here use a private key fixture
27pchrisl
commented
Oct 11, 2021
|
|
||
| $handler = $list->resolve(); | ||
| $handler($command, new Request('POST', $endpoint)); | ||
| $handler($command, new Request('POST', $endpoint))->wait(false); |
Contributor
Author
There was a problem hiding this comment.
This fixes an issue that only showed itself in Guzzle or PHP 8.x
27pchrisl
commented
Oct 11, 2021
| { | ||
| } | ||
|
|
||
| public function setUp(): void |
Contributor
Author
There was a problem hiding this comment.
PHPUnit 9 added the void return type here, needing the polyfilled behaviour to compile on earlier PHP versions
27pchrisl
commented
Oct 11, 2021
| $loader = require __DIR__.'/../vendor/autoload.php'; | ||
|
|
||
| if (!class_exists('\PHPUnit\Framework\Constraint\RegularExpression')) { | ||
| if ( ! defined('PHPUNIT_COMPOSER_INSTALL')) { |
Contributor
Author
There was a problem hiding this comment.
To support the @runInSeparateProcess annotation
Member
|
Hi @27pchrisl, Going to close this in favor of #2403. We want to get it merged relatively soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds support for running tests against PHP 8.0 and 8.1, and upgrades to PHPUnit 9 (for supported PHP versions).
The changes implement polyfills for older PHPUnit versions to add missing 9.x methods, and restores older methods that newer PHPUnit versions removed. This is implemented through the
PHPUnitCompatTrait, dynamically selected inbootstrap.php.As PHPUnit 9 added the
voidreturn type tosetUp,tearDown,setUpBeforeClassandtearDownAfterClass, the polyfills provide_-prefixed versions of these methods to support all PHP versions (eg_setUp).The only actual failing
srccode in 8.0/8.1 was the same as fixed in #2331. All other changes are only to the test suite. I'm commenting below on notable changes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.