Fix DateTimeResult on PHP 8.1 #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Friendly ping @SamRemis. :) |
stof
reviewed
Oct 20, 2021
| } | ||
|
|
||
| /** | ||
| * @param $iso8601Timestamp |
There was a problem hiding this comment.
should rather be @param string $iso8601Timestamp
Contributor
Author
There was a problem hiding this comment.
it seems to accept non-string params too, otherwise the is_string check would be dead code. adding propper type doc is out of scope here. I've just removed some invalid syntax.
SamRemis
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2327. Replaces #2331.