-
Notifications
You must be signed in to change notification settings - Fork 1.2k
PHP 8.0, 8.1, PHPUnit 9 support + automated check for php compatibility #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
64aac67
PHP 8.0, 8.1, PHPUnit 9 support
27pchrisl 5963c8c
Replace key-fixture in CloudFront-tests with generated keys
Zombaya 73595b3
Additional changes to unittest for phpunit9-compatibility
Zombaya 69e7187
Fix problems with non-fully-reset environment-variables after test
Zombaya 22c3c77
Add changelog document
Zombaya 3fa4d92
Small rewrites of unittests because of deprecation-warnings in phpuni…
Zombaya 82715b9
Remove warnings from usage of arguments of wrong type in php 8.1
Zombaya bebfcc7
Solve failing unittest CloudFront\SignerTest::testBadPrivateKeyPath()
Zombaya eccd896
switch to double pipe
stobrien89 863a65a
Formatting fixes
Zombaya bce4721
Additional methods added to PHPUnitCompatibilitityTraits
Zombaya 8f4b64e
PHP 8.0, 8.1, PHPUnit 9 support
27pchrisl 1c4109d
Replace key-fixture in CloudFront-tests with generated keys
Zombaya 7dd0db1
Additional changes to unittest for phpunit9-compatibility
Zombaya a129990
Fix problems with non-fully-reset environment-variables after test
Zombaya 22374fc
Add changelog document
Zombaya 991312f
Small rewrites of unittests because of deprecation-warnings in phpuni…
Zombaya a57b51f
Remove warnings from usage of arguments of wrong type in php 8.1
Zombaya f07ec26
Solve failing unittest CloudFront\SignerTest::testBadPrivateKeyPath()
Zombaya d6474a8
switch to double pipe
stobrien89 c2def67
Formatting fixes
Zombaya c6f3be2
Additional methods added to PHPUnitCompatibilitityTraits
Zombaya 71f3ec5
fix conflicts/warnings
b7b6f7e
update tests
f49a0ef
refactor jsonbody getcontenttype
ceb60cc
add compattrait to endpointparametermiddlewaretest
7ce24b4
add compattrait to endpointparametermiddlewaretest
6d1e8aa
add update to instanceprofileprovider
e98701e
Merge branch 'master' into phpcompatibilityChecker
stobrien89 9634dfa
Replace PHPUnitCompatTrait with packages yoast/phpunit-polyfills and …
Zombaya 661ac2f
Replace $this->expectNotToPerformAssertions() with $this->addToAssert…
Zombaya 4c34478
Merge remote-tracking branch 'upstream/master' into phpcompatibilityC…
Zombaya e67a48e
fix spacing
stobrien89 06e01bf
Fix spacing
stobrien89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove warnings from usage of arguments of wrong type in php 8.1
- Loading branch information
commit a57b51f860cd9079e195d220f88864a6d79882c9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -429,7 +429,7 @@ public function __construct(array $args) | |
| */ | ||
| public static function isBucketDnsCompatible($bucket) | ||
SamRemis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| $bucketLen = strlen($bucket); | ||
| $bucketLen = $bucket !== null ? strlen($bucket) : 0; | ||
|
||
|
|
||
| return ($bucketLen >= 3 && $bucketLen <= 63) && | ||
| // Cannot look like an IP address | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this multiple lines?