Fix self callables #2518
Merged
Fix self callables #2518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Member
|
Hi @driesvints, Sorry for the delay. And thanks for the contribution. LGTM 🚢 . Will go out in today's release. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are necessary to solve some deprecation notices for PHP 8.2 where
self::is used in a callable context. This isn't supported anymore. I didn't add any tests because this should technically get a new 8.2 build. However, the 8.0 and 8.1 builds are also still pending so I figured it didn't make sense to add an 8.2 build before that PR was merged: #2403Here's the upgrade notice: https://github.com/php/php-src/blob/PHP-8.2/UPGRADING#L157-L167
Right now, we're trying to get a passing PHP 8.2 build for Laravel. This library is one of the last blockers to get a passing build. See failures in the Laravel build:
It would be great to get a merge and a release for this @SamRemis. Thanks!