Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
release: v0.20.6 (#989)
The Dyanmic proxies were missing an implementation of `__setattr__`,
which caused setter invokations to not be forwarded to the `node`
process.

This is what causes aws/aws-cdk#5032
  • Loading branch information
RomainMuller authored Nov 14, 2019
commit 17f281e5647087acedff8e5d8ad4a80c431b086b
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.20.6](https://github.com/aws/jsii/compare/v0.20.5...v0.20.6) (2019-11-14)


### Bug Fixes

* **python:** dynamic proxies handling of setters ([eec9640](https://github.com/aws/jsii/commit/eec96403fea1e940b744e40d54a35535b766851d)), closes [aws/aws-cdk#5032](https://github.com/aws/aws-cdk/issues/5032)





## [0.20.5](https://github.com/aws/jsii/compare/v0.20.4...v0.20.5) (2019-11-13)


Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@
"rejectCycles": true
}
},
"version": "0.20.5"
"version": "0.20.6"
}
8 changes: 8 additions & 0 deletions packages/codemaker/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.20.6](https://github.com/aws/jsii/compare/v0.20.5...v0.20.6) (2019-11-14)

**Note:** Version bump only for package codemaker





## [0.20.5](https://github.com/aws/jsii/compare/v0.20.4...v0.20.5) (2019-11-13)

**Note:** Version bump only for package codemaker
Expand Down
2 changes: 1 addition & 1 deletion packages/codemaker/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "codemaker",
"version": "0.20.5",
"version": "0.20.6",
"description": "A tiny utility for generating source code",
"license": "Apache-2.0",
"author": {
Expand Down
8 changes: 8 additions & 0 deletions packages/jsii-build-tools/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.20.6](https://github.com/aws/jsii/compare/v0.20.5...v0.20.6) (2019-11-14)

**Note:** Version bump only for package jsii-build-tools





## [0.20.5](https://github.com/aws/jsii/compare/v0.20.4...v0.20.5) (2019-11-13)

**Note:** Version bump only for package jsii-build-tools
Expand Down
2 changes: 1 addition & 1 deletion packages/jsii-build-tools/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jsii-build-tools",
"version": "0.20.5",
"version": "0.20.6",
"private": true,
"description": "Internal repository-level tools",
"license": "Apache-2.0",
Expand Down
8 changes: 8 additions & 0 deletions packages/jsii-calc-base-of-base/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.20.6](https://github.com/aws/jsii/compare/v0.20.5...v0.20.6) (2019-11-14)

**Note:** Version bump only for package @scope/jsii-calc-base-of-base





## [0.20.5](https://github.com/aws/jsii/compare/v0.20.4...v0.20.5) (2019-11-13)

**Note:** Version bump only for package @scope/jsii-calc-base-of-base
Expand Down
6 changes: 3 additions & 3 deletions packages/jsii-calc-base-of-base/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@scope/jsii-calc-base-of-base",
"version": "0.20.5",
"version": "0.20.6",
"private": true,
"description": "An example transitive dependency for jsii-calc.",
"license": "Apache-2.0",
Expand Down Expand Up @@ -29,8 +29,8 @@
"test:update": "npm run build && UPDATE_DIFF=1 npm run test"
},
"devDependencies": {
"jsii": "^0.20.5",
"jsii-build-tools": "^0.20.5"
"jsii": "^0.20.6",
"jsii-build-tools": "^0.20.6"
},
"jsii": {
"outdir": "dist",
Expand Down
6 changes: 3 additions & 3 deletions packages/jsii-calc-base-of-base/test/assembly.jsii
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"description": "An example transitive dependency for jsii-calc.",
"homepage": "https://github.com/aws/jsii",
"jsiiVersion": "0.20.5",
"jsiiVersion": "0.20.6",
"license": "Apache-2.0",
"name": "@scope/jsii-calc-base-of-base",
"repository": {
Expand Down Expand Up @@ -110,6 +110,6 @@
]
}
},
"version": "0.20.5",
"fingerprint": "DBNUXuxkMzbp98sCDFuv55EmqNEx4enS6ObVZXVoveI="
"version": "0.20.6",
"fingerprint": "vpWOuY/fOXC3L1MfyV4jwakpEjHt9QryEzq86GzZyzQ="
}
8 changes: 8 additions & 0 deletions packages/jsii-calc-base/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.20.6](https://github.com/aws/jsii/compare/v0.20.5...v0.20.6) (2019-11-14)

**Note:** Version bump only for package @scope/jsii-calc-base





## [0.20.5](https://github.com/aws/jsii/compare/v0.20.4...v0.20.5) (2019-11-13)

**Note:** Version bump only for package @scope/jsii-calc-base
Expand Down
10 changes: 5 additions & 5 deletions packages/jsii-calc-base/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@scope/jsii-calc-base",
"version": "0.20.5",
"version": "0.20.6",
"private": true,
"description": "An example direct dependency for jsii-calc.",
"license": "Apache-2.0",
Expand Down Expand Up @@ -29,14 +29,14 @@
"test:update": "npm run build && UPDATE_DIFF=1 npm run test"
},
"dependencies": {
"@scope/jsii-calc-base-of-base": "^0.20.5"
"@scope/jsii-calc-base-of-base": "^0.20.6"
},
"peerDependencies": {
"@scope/jsii-calc-base-of-base": "^0.20.5"
"@scope/jsii-calc-base-of-base": "^0.20.6"
},
"devDependencies": {
"jsii": "^0.20.5",
"jsii-build-tools": "^0.20.5"
"jsii": "^0.20.6",
"jsii-build-tools": "^0.20.6"
},
"jsii": {
"outdir": "dist",
Expand Down
10 changes: 5 additions & 5 deletions packages/jsii-calc-base/test/assembly.jsii
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"module": "scope.jsii_calc_base_of_base"
}
},
"version": "0.20.5"
"version": "0.20.6"
}
},
"dependencyClosure": {
Expand All @@ -54,12 +54,12 @@
"module": "scope.jsii_calc_base_of_base"
}
},
"version": "0.20.5"
"version": "0.20.6"
}
},
"description": "An example direct dependency for jsii-calc.",
"homepage": "https://github.com/aws/jsii",
"jsiiVersion": "0.20.5",
"jsiiVersion": "0.20.6",
"license": "Apache-2.0",
"name": "@scope/jsii-calc-base",
"repository": {
Expand Down Expand Up @@ -173,6 +173,6 @@
"name": "IBaseInterface"
}
},
"version": "0.20.5",
"fingerprint": "rgs3oNsQ/gwJQH4bxwfnHVbL45BPcIUGMEG6t3M+zpc="
"version": "0.20.6",
"fingerprint": "fBGUnzsbBSW/aAlp2GrET4hzbYQt22fKLAzVUBAk44I="
}
8 changes: 8 additions & 0 deletions packages/jsii-calc-lib/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.20.6](https://github.com/aws/jsii/compare/v0.20.5...v0.20.6) (2019-11-14)

**Note:** Version bump only for package @scope/jsii-calc-lib





## [0.20.5](https://github.com/aws/jsii/compare/v0.20.4...v0.20.5) (2019-11-13)

**Note:** Version bump only for package @scope/jsii-calc-lib
Expand Down
10 changes: 5 additions & 5 deletions packages/jsii-calc-lib/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@scope/jsii-calc-lib",
"version": "0.20.5",
"version": "0.20.6",
"private": true,
"description": "A simple calcuator library built on JSII.",
"deprecated": "Really just deprecated for shows...",
Expand Down Expand Up @@ -31,14 +31,14 @@
"test:update": "npm run build && UPDATE_DIFF=1 npm run test"
},
"dependencies": {
"@scope/jsii-calc-base": "^0.20.5"
"@scope/jsii-calc-base": "^0.20.6"
},
"peerDependencies": {
"@scope/jsii-calc-base": "^0.20.5"
"@scope/jsii-calc-base": "^0.20.6"
},
"devDependencies": {
"jsii": "^0.20.5",
"jsii-build-tools": "^0.20.5"
"jsii": "^0.20.6",
"jsii-build-tools": "^0.20.6"
},
"jsii": {
"outdir": "dist",
Expand Down
12 changes: 6 additions & 6 deletions packages/jsii-calc-lib/test/assembly.jsii
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"module": "scope.jsii_calc_base"
}
},
"version": "0.20.5"
"version": "0.20.6"
}
},
"dependencyClosure": {
Expand All @@ -54,7 +54,7 @@
"module": "scope.jsii_calc_base"
}
},
"version": "0.20.5"
"version": "0.20.6"
},
"@scope/jsii-calc-base-of-base": {
"targets": {
Expand All @@ -77,7 +77,7 @@
"module": "scope.jsii_calc_base_of_base"
}
},
"version": "0.20.5"
"version": "0.20.6"
}
},
"description": "A simple calcuator library built on JSII.",
Expand All @@ -86,7 +86,7 @@
"stability": "deprecated"
},
"homepage": "https://github.com/aws/jsii",
"jsiiVersion": "0.20.5",
"jsiiVersion": "0.20.6",
"license": "Apache-2.0",
"name": "@scope/jsii-calc-lib",
"repository": {
Expand Down Expand Up @@ -538,6 +538,6 @@
]
}
},
"version": "0.20.5",
"fingerprint": "Qdjlff+inHWhi0ddSAbkEfQmeMTm5e7RSWH+V8izQgo="
"version": "0.20.6",
"fingerprint": "lSdVmcJ5wMQNs04OBlxR/VpJgx02vYR/ulFbQrWwbD0="
}
11 changes: 11 additions & 0 deletions packages/jsii-calc/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.20.6](https://github.com/aws/jsii/compare/v0.20.5...v0.20.6) (2019-11-14)


### Bug Fixes

* **python:** dynamic proxies handling of setters ([eec9640](https://github.com/aws/jsii/commit/eec96403fea1e940b744e40d54a35535b766851d)), closes [aws/aws-cdk#5032](https://github.com/aws/aws-cdk/issues/5032)





## [0.20.5](https://github.com/aws/jsii/compare/v0.20.4...v0.20.5) (2019-11-13)


Expand Down
29 changes: 29 additions & 0 deletions packages/jsii-calc/lib/compliance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2266,3 +2266,32 @@ export class Demonstrate982 {

public constructor() { }
}

/**
* Make sure that setters are properly called on objects with interfaces
*/
export interface IObjectWithProperty {
property: string;
wasSet(): boolean;
}
export class ObjectWithPropertyProvider {
public static provide(): IObjectWithProperty {
class Impl implements IObjectWithProperty {
private _property: string = '';
private _wasSet = false;

public get property() { return this._property; }
public set property(value: string) {
this._property = value;
this._wasSet = true;
}

public wasSet() {
return this._wasSet;
}
}
return new Impl();
}

private constructor() { }
}
18 changes: 9 additions & 9 deletions packages/jsii-calc/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jsii-calc",
"version": "0.20.5",
"version": "0.20.6",
"private": true,
"description": "A simple calcuator built on JSII.",
"stability": "experimental",
Expand Down Expand Up @@ -31,19 +31,19 @@
"test:update": "npm run build && UPDATE_DIFF=1 npm run test"
},
"dependencies": {
"@scope/jsii-calc-base": "^0.20.5",
"@scope/jsii-calc-base-of-base": "^0.20.5",
"@scope/jsii-calc-lib": "^0.20.5",
"@scope/jsii-calc-base": "^0.20.6",
"@scope/jsii-calc-base-of-base": "^0.20.6",
"@scope/jsii-calc-lib": "^0.20.6",
"jsii-calc-bundled": "file:../@fixtures/jsii-calc-bundled"
},
"peerDependencies": {
"@scope/jsii-calc-base": "^0.20.5",
"@scope/jsii-calc-base-of-base": "^0.20.5",
"@scope/jsii-calc-lib": "^0.20.5"
"@scope/jsii-calc-base": "^0.20.6",
"@scope/jsii-calc-base-of-base": "^0.20.6",
"@scope/jsii-calc-lib": "^0.20.6"
},
"devDependencies": {
"jsii": "^0.20.5",
"jsii-build-tools": "^0.20.5"
"jsii": "^0.20.6",
"jsii-build-tools": "^0.20.6"
},
"jsii": {
"outdir": "dist",
Expand Down
Loading