Skip to content

Updating to new version of AWS SDK 2.10.56, changing Netty client defaults. #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Updating to new version of AWS SDK 2.10.56, changing Netty client defaults. #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8603308
Updating AWS SDK version to 2.10.56
joshua-kim Jan 27, 2020
fafd62c
Changing default netty client to use 60 second ping health check time…
joshua-kim Jan 27, 2020
7a09b77
Tuning default request response timeout to 60 seconds.
joshua-kim Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion amazon-kinesis-client/src/main/java/software/amazon/kinesis/common/KinesisClientUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,22 @@

package software.amazon.kinesis.common;

import software.amazon.awssdk.http.Protocol;
import software.amazon.awssdk.http.nio.netty.Http2Configuration;
import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
import software.amazon.awssdk.services.kinesis.KinesisAsyncClient;
import software.amazon.awssdk.services.kinesis.KinesisAsyncClientBuilder;

import java.time.Duration;

/**
* Utility to setup KinesisAsyncClient to be used with KCL.
*/
public class KinesisClientUtil {

private static int INITIAL_WINDOW_SIZE_BYTES = 10 * 1024 * 1024;
private static long HEALTH_CHECK_PING_PERIOD_MILLIS = 60 * 1000;

/**
* Creates a client from a builder.
*
Expand All @@ -35,6 +42,9 @@ public static KinesisAsyncClient createKinesisAsyncClient(KinesisAsyncClientBuil
}

public static KinesisAsyncClientBuilder adjustKinesisClientBuilder(KinesisAsyncClientBuilder builder) {
return builder.httpClientBuilder(NettyNioAsyncHttpClient.builder().maxConcurrency(Integer.MAX_VALUE));
return builder.httpClientBuilder(NettyNioAsyncHttpClient.builder().maxConcurrency(Integer.MAX_VALUE)
.http2Configuration(Http2Configuration.builder().initialWindowSize(INITIAL_WINDOW_SIZE_BYTES)
.healthCheckPingPeriod(Duration.ofMillis(HEALTH_CHECK_PING_PERIOD_MILLIS)).build())
.protocol(Protocol.HTTP2));
}
}
2 changes: 1 addition & 1 deletion amazon-kinesis-client/src/main/java/software/amazon/kinesis/lifecycle/ShardConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
@KinesisClientInternalApi
public class ShardConsumer {

public static final int MAX_TIME_BETWEEN_REQUEST_RESPONSE = 35000;
public static final int MAX_TIME_BETWEEN_REQUEST_RESPONSE = 60 * 1000;
private final RecordsPublisher recordsPublisher;
private final ExecutorService executorService;
private final ShardInfo shardInfo;
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
</scm>

<properties>
<awssdk.version>2.10.25</awssdk.version>
<awssdk.version>2.10.56</awssdk.version>
</properties>

<licenses>
Expand Down