Set security headers on CloudFront responses #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
force-pushed
the
set-security-headers
branch
2 times, most recently
from
96b5bc1 to
1d75724
Compare
added 8 commits
June 19, 2020 19:48
This could be necessary in the future, so I want to lay the groundwork now. Also, it's a potentially common need in development.
Swagger UI doesn't offer any facilities to clean up after itself, so we have to tolerate it.
When starting from scratch, if you go to the admin panel, set the first API to display, and switch back to the APIs page, it's now out of date with what's server-side.
ghost
force-pushed
the
set-security-headers
branch
from
1d75724 to
2191174
Compare
ghost
marked this pull request as ready for review
ghost
requested review from
MynockSpit,
a-tan,
etsung-aws,
jiyou95 and
skylarbemus
as code owners
|
Review link ignoring last commit: https://github.com/awslabs/aws-api-gateway-developer-portal/pull/414/files/6107223f8b701a81c16b5ef5d39f6f22525564fe |
skylarbemus
approved these changes
Jun 22, 2020
zil-aws
approved these changes
Jun 22, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.