Fix build issues and upgrade template node version to 16

.gitignore

@@ -1,10 +1,11 @@
 # top-level and lambda function specific
 /node_modules
 /coverage
-/lambdas/static-asset-uploader/build/config.js
+/lambdas/static-asset-uploader/build
 /lambdas/coverage
 
 # devportal specific
+/dev-portal/build
 
 # we're committing the artifacts, don't need the modules
 # note, though, that we do need our patched version of swagger-ui and not the npm version
@@ -33,4 +34,6 @@ cognito.js
 .idea
 .vscode
 .eslintcache
-*.iml
+*.iml
+
+

cloudformation/template.yaml

@@ -1227,7 +1227,7 @@ Resources:
       Description: 'Common code used by lambdas'
       ContentUri: ../lambdas/common-layer/
       CompatibleRuntimes:
-        - nodejs12.x
+        - nodejs16.x
 
   DevPortalLambdaFunction:
     Type: AWS::Serverless::Function
@@ -1236,7 +1236,7 @@ Resources:
       Handler: index.handler
       MemorySize: 1024
       Role: !GetAtt BackendLambdaExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 30
       Environment:
         Variables:
@@ -1279,7 +1279,7 @@ Resources:
   #     Handler: index.handler
   #     MemorySize: 128
   #     Role: !GetAtt BackendLambdaExecutionRole.Arn
-  #     Runtime: nodejs12.x
+  #     Runtime: nodejs16.x
   #     Timeout: 30
   #     Layers:
   #       - !Ref LambdaCommonLayer
@@ -1292,7 +1292,7 @@ Resources:
       Handler: index.handler
       MemorySize: 128
       Role: !GetAtt CognitoPreSignupTriggerExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 3
       Environment:
         Variables:
@@ -1308,7 +1308,7 @@ Resources:
       Handler: index.handler
       MemorySize: 128
       Role: !GetAtt CognitoPostConfirmationTriggerExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 3
       Environment:
         Variables:
@@ -1326,7 +1326,7 @@ Resources:
       Handler: index.handler
       MemorySize: 128
       Role: !GetAtt CognitoPostAuthenticationTriggerExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 3
       Environment:
         Variables:
@@ -1455,7 +1455,7 @@ Resources:
   CognitoUserPoolClientSettingsBackingFn:
     Type: AWS::Serverless::Function
     Properties:
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       MemorySize: 128
       Timeout: 300
       CodeUri: ../lambdas/cfn-cognito-user-pools-client-settings
@@ -1539,7 +1539,7 @@ Resources:
   CognitoUserPoolDomainBackingFn:
     Type: AWS::Serverless::Function
     Properties:
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       MemorySize: 128
       Timeout: 300
       CodeUri: ../lambdas/cfn-cognito-user-pools-domain
@@ -1710,7 +1710,7 @@ Resources:
       Handler: index.handler
       MemorySize: 128
       Role: !GetAtt CatalogUpdaterLambdaExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 20
       Environment:
         Variables:
@@ -1735,7 +1735,7 @@ Resources:
       Handler: index.handler
       MemorySize: 512
       Role: !GetAtt AssetUploaderLambdaExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 300
       Environment:
         Variables:
@@ -1789,7 +1789,7 @@ Resources:
       Handler: replicator.handler
       MemorySize: 128
       Role: !GetAtt CloudFrontEdgeReplicatorRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 300
       AutoPublishAlias: Live
       Environment:
@@ -1958,7 +1958,7 @@ Resources:
       Handler: index.handler
       MemorySize: 512
       Role: !GetAtt DumpV3AccountDataExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       Timeout: 300
       Environment:
         Variables:
@@ -2068,7 +2068,7 @@ Resources:
       Handler: index.handler
       MemorySize: 512
       Role: !GetAtt UserGroupImporterExecutionRole.Arn
-      Runtime: nodejs12.x
+      Runtime: nodejs16.x
       # Use the default max timeout duration.
       Timeout: 900
       Environment:

dev-portal/.eslintrc.js

@@ -1,7 +1,7 @@
 'use strict'
 
 module.exports = {
-  extends: ['react-app', '../.eslintrc.js'],
+  extends: ['react-app'],
   overrides: [
     {
       files: ['.eslintrc.js', './*.js'],