Skip to content

Set thread names to help debugging #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 4, 2022
Merged

Set thread names to help debugging #519

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e08bfdb
names for event-loop threads and host-resolver thread
graebm Oct 1, 2022
5b8e0cb
format
graebm Oct 1, 2022
2b8efb8
fix compiler warnings about buffer being too small. Yes, I know in th…
graebm Oct 1, 2022
d5f7884
give good names to functions that block, so people don't think they'r…
graebm Oct 8, 2022
39bff28
linux fixes
graebm Oct 8, 2022
f94d5e5
Merge branch 'main' into thread-name
graebm Oct 21, 2022
0f50f29
fix linux
graebm Oct 8, 2022
a642c5d
fix windows
graebm Oct 21, 2022
a2d32a3
epoll proof alarm works off checksum instead of git hash. It was impo…
graebm Oct 21, 2022
c3bf416
clang-format
graebm Oct 21, 2022
b3a9649
Merge branch 'thread-name' of github.com:awslabs/aws-c-io into thread…
graebm Oct 21, 2022
8d6ce3e
better name for macro
graebm Oct 21, 2022
ee42c97
name event_loop_group cleanup thread
graebm Oct 28, 2022
8f2eca4
Merge branch 'main' into thread-name
graebm Nov 2, 2022
806ae45
cast to int, as Bret recommends
graebm Nov 2, 2022
ba6ec72
Merge branch 'main' into thread-name
graebm Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix compiler warnings about buffer being too small. Yes, I know in th… 
…eory it's too small which is why I used safe snprintf. Whatever, bigger buffer is path of least resistence
  • Loading branch information
@graebm
graebm committed Oct 1, 2022
commit 2b8efb8d76fa0a70f89a40f7c2466dc54374de8c
8 changes: 3 additions & 5 deletions source/event_loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ static void s_aws_event_loop_group_shutdown_async(struct aws_event_loop_group *e

aws_thread_init(&cleanup_thread, el_group->allocator);

struct aws_thread_options thread_options;
AWS_ZERO_STRUCT(thread_options);
thread_options.cpu_id = -1;
struct aws_thread_options thread_options = *aws_default_thread_options();
thread_options.join_strategy = AWS_TJS_MANAGED;

aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options);
Expand Down Expand Up @@ -131,8 +129,8 @@ static struct aws_event_loop_group *s_event_loop_group_new(
thread_options.cpu_id = usable_cpus[i].cpu_id;
}

char thread_name[16] = {0};
snprintf(thread_name, sizeof(thread_name), "aws-io %d/%d", (int)i + 1, (int)el_count);
char thread_name[32] = {0};
snprintf(thread_name, sizeof(thread_name), "aws-io %d/%d", i + 1, el_count);
thread_options.name = aws_byte_cursor_from_c_str(thread_name);

struct aws_event_loop *loop = new_loop_fn(alloc, &options, new_loop_user_data);
Expand Down