Skip to content

Conversation

@waahm7
Copy link
Contributor

@waahm7 waahm7 commented Nov 2, 2022

Description of changes:

  • Use mac 12
  • Optional downstream build
  • Use const for host_resolution_config

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 marked this pull request as ready for review November 2, 2022 17:35
@waahm7 waahm7 changed the title Update ci Update CI to fix downstream build Nov 9, 2022
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

"downstream": [
{ "name": "aws-c-mqtt" },
{ "name": "aws-c-http" }
{ "name": "aws-c-http" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's put HTTP before MQTT, since MQTT sometimes uses HTTP

* This object is deep-copied by bootstrap.
* */
struct aws_host_resolution_config *host_resolution_config;
const struct aws_host_resolution_config *host_resolution_config;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waahm7 waahm7 merged commit b51cb53 into main Nov 10, 2022
@waahm7 waahm7 deleted the update-ci-io branch November 10, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants