Skip to content

CborDecoder initialize m_lastError in constructor #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

CborDecoder initialize m_lastError in constructor #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eccfb68
CborDecoder initialize m_lastError in constructor
sbaluja Sep 25, 2025
5874a72
Add CborDecoder LastError regression test
sbaluja Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/cbor/Cbor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ namespace Aws
*
*****************************************************/
CborDecoder::CborDecoder(ByteCursor src, Crt::Allocator *allocator) noexcept
: m_lastError(AWS_ERROR_SUCCESS)
{
m_decoder = aws_cbor_decoder_new(allocator, src);
}
Expand Down
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ endif()

add_test_case(CborSanityTest)
add_test_case(CborTimeStampTest)
add_test_case(CborLastErrorTest)

generate_cpp_test_driver(${TEST_BINARY_NAME})

Expand Down
17 changes: 17 additions & 0 deletions tests/CborTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,3 +240,20 @@ static int s_CborTimeStampTest(struct aws_allocator *allocator, void *ctx)
}

AWS_TEST_CASE(CborTimeStampTest, s_CborTimeStampTest)

static int s_CborLastErrorTest(struct aws_allocator *allocator, void *ctx)
{
/**
* Test the last error is initialzed correctly.
*/
(void)ctx;
{
ApiHandle apiHandle(allocator);
Cbor::CborDecoder decoder({});
ASSERT_INT_EQUALS(decoder.LastError(), AWS_ERROR_UNKNOWN);
}

return AWS_OP_SUCCESS;
}

AWS_TEST_CASE(CborLastErrorTest, s_CborLastErrorTest)