This repository was archived by the owner on May 21, 2025. It is now read-only.
Support v2 payloads for httpadapter
#112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides an equivalent implementation to `handlerfunc.HandlerFuncAdapterV2` that will proxy `events.APIGatewayV2HTTPRequest` to a `http.Handler`.
A `http.HandlerFunc` implements the `http.Handler` interface so this package is redundant. To avoid breaking backwards compatibility, this uses type aliases and preserves the `handlerfunc.New` and `handlerfunc.NewV2` methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#80 implemented support for
handlerfuncbut nothttpadapter.This provides an equivalent implementation to
handlerfunc.HandlerFuncAdapterV2that will proxyevents.APIGatewayV2HTTPRequestto ahttp.Handler.A
http.HandlerFuncimplements thehttp.Handlerinterface so I've implementedhandlerfuncin terms ofhttpadapter. This will avoid implementation drift. To avoid breaking backwards compatibility, this uses type aliases and preserves thehandlerfunc.Newandhandlerfunc.NewV2methods.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.