This repository was archived by the owner on May 21, 2025. It is now read-only.
Added support for multi-value headers #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapessi
reviewed
Feb 19, 2019
core/response.go
Outdated
| Body: output, | ||
| IsBase64Encoded: isBase64, | ||
| StatusCode: r.status, | ||
| MultiValueHeaders: textproto.MIMEHeader(r.headers), |
There was a problem hiding this comment.
Why use the MIMEHeader from textproto instead of the Header object from net/http? They are both aliases of map[string][]string
There was a problem hiding this comment.
No strong reason for that. While browsing through Golang's source code I found that Header object from net/http basically reuses a lot of functions from MIMEHeader from textproto, and provides functionality I didn't need. (Ref: https://golang.org/src/net/http/header.go). Since I only needed a map[string][]string, I chose the lightweight one.
Now I think more of that, I don't think it improves performance yet increases confusion in code. I've reverted to use Header from net/http.
huyphan
force-pushed
the
multi-value-headers
branch
from
846a2b3 to
d7b2b4e
Compare
sapessi
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #30
Description of changes:
MultiValueHeadersfield rather thanHeadersfield. This allows lambda-based service to send multiple values for the same header -- one notable use case being "Set-Cookie".By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.