-
Notifications
You must be signed in to change notification settings - Fork 376
Documentation fixes with some linting #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c1e71e2
Fix minor typos
darrenmeehan 1180ed1
Avoid long literal lacking separators
darrenmeehan 6f80780
Add description
darrenmeehan 1e250dd
Update README to use hello world example
darrenmeehan f2dd59c
Update cli changes to work with aws cli v2
darrenmeehan 0d2872e
Ignore outputs from follow instructions
darrenmeehan 8a76469
Remove Travis button as it's no longer used.
darrenmeehan acce9a9
Merge pull request #1 from Darrenmeehan/patch-1
darrenmeehan f3337db
Remove client from description
darrenmeehan 6bb60b9
Capitalise runtime in description
darrenmeehan 56a745f
Document --cli-binary-format seperately
darrenmeehan 1ef54a8
Fixed name for macro
darrenmeehan 00f59db
Fix typo
darrenmeehan d508b92
Highlight tokia requirement and improve clarity
darrenmeehan 7dea464
Address whitespace issue
darrenmeehan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
/target | ||
/.cargo | ||
lambda-runtime/libtest.rmeta | ||
lambda-runtime/libtest.rmeta | ||
|
||
# Built AWS Lambda zipfile | ||
lambda.zip | ||
|
||
# output.json from example docs | ||
output.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
name = "lambda" | ||
version = "0.1.0" | ||
authors = ["David Barsky <[email protected]>"] | ||
description = "AWS Lambda Runtime." | ||
edition = "2018" | ||
|
||
[features] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might drop the "client" part of this. That's an implementation detail most users won't likely care or care to know about. Just calling this "AWS Lambda Rust runtime" might get the point across and be a little bit more inline with https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I've addressed this in f3337db