Skip to content

Add missing license fields in lambda and lambda-attributes crates #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add missing license fields in lambda and lambda-attributes crates #251

merged 1 commit into from
Jan 19, 2021

Conversation

stanislav-tkach
Copy link
Contributor

@stanislav-tkach stanislav-tkach commented Aug 10, 2020 •
edited
Loading

Description of changes: License isn't specified in the lambda and lambda-attributes Cargo.toml files. The repository contains the LICENSE file, so I have used "Apache-2.0" from that file.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

rimutaka
rimutaka approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@rimutaka rimutaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@stanislav-tkach
Copy link
Contributor Author

Sorry to bother, but can this be fixed somehow? I'm using cargo-deny to control licenses of my project dependencies and this is kind of blocking me (EmbarkStudios/cargo-deny#250).

@Veetaha
Copy link
Contributor

Veetaha commented Aug 26, 2020

cc @davidbarsky , looks like we can merge it right away

@stanislav-tkach stanislav-tkach mentioned this pull request Aug 30, 2020
Closed
@calavera calavera mentioned this pull request Dec 16, 2020
Closed
coltonweaver
coltonweaver reviewed Jan 19, 2021
View reviewed changes
Copy link
Contributor

@coltonweaver coltonweaver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution and apologies on the delay!

@coltonweaver coltonweaver merged commit d9998e7 into awslabs:master Jan 19, 2021
@stanislav-tkach stanislav-tkach deleted the missing-license-toml branch January 20, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rimutaka rimutaka rimutaka approved these changes

@coltonweaver coltonweaver coltonweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stanislav-tkach @Veetaha @rimutaka @coltonweaver