Skip to content

Conversation

endor
Copy link
Contributor

@endor endor commented Sep 14, 2020

Issue #, if available:

Description of changes:

The cookies are available as separate field when LambdaRequest::ApiGatewayV2 is deserialized, but they did not get passed into the headers field of Request and so couldn't be used in the lambda.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@endor endor force-pushed the pass-cookies-to-request branch from 6d2f7bb to a06c34c Compare September 14, 2020 13:05
Copy link
Contributor

@softprops softprops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me

Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this!

@davidbarsky davidbarsky merged commit ed40f5a into awslabs:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants