Skip to content

Conversation

Bryson14
Copy link
Contributor

@Bryson14 Bryson14 commented Jan 25, 2024

Issue #, if available:

Description of changes:

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

This would have been very helpful as I want making a lambda function that recieved paths from api gateway!
Update axum documentation to include env var of stage name
@calavera
Copy link
Contributor

Not everyone that uses the Lambda Runtime uses APIGW. I appreciate the intention, but I'd rather leave the example agnostic, as it works as expected by default for any other integrations.

Copy link
Contributor

@greenwoodcm greenwoodcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution!

@greenwoodcm greenwoodcm merged commit 9f8f250 into awslabs:main Jan 25, 2024
@greenwoodcm
Copy link
Contributor

oops! sorry, i missed @calavera 's comment asking that we leave this example agnostic to APIG. @calavera happy to revert and restart the discussion on if we want this in the example. let me know.

@sn99 sn99 mentioned this pull request Jan 28, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants