Skip to content

Conversation

lmammino
Copy link
Contributor

Issue #, if available: #797

Description of changes: Adds more tests on the deserialization of REST and HTTP ApiGw events being generated by sam local start-api

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnusunny bnusunny merged commit a837f3c into awslabs:main Jan 29, 2024
@lmammino lmammino deleted the investigate-issue-797 branch January 29, 2024 10:43
@lmammino
Copy link
Contributor Author

lmammino commented Jan 29, 2024

Thanks for merging this, @bnusunny!

Any pointer on what might be causing #797 or where to continue the investigation from?

@bnusunny
Copy link
Contributor

@lmammino I will take a look today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants