fix: support string or [string] when deserializing IamPolicyStatement
#854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tement` `Action` and `Resource` allow both `string` and `[string]` as values. Support deserializing `IamPolicyStatement` with either of these values. fixes: awslabs#853
aesterline
force-pushed
the
fix/aesterline/string-or-string-slice
branch
from
c5d2b20 to
5a94246
Compare
|
The examples failure is unrelated to these changes. I'm fixing it in #855 |
calavera
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionandResourceallow bothstringand[string]as values. Support deserializingIamPolicyStatementwith either of these values.Issue #, if available:
fixes: #853
Description of changes:
I thought about changing the type of the
actionandresourcefields to be another type that was an enumeration, but it felt like a backward breaking change and I wasn't sure that was acceptable. It seems like there are other cases ofdeserialize_with, so I thought I would give that approach a shot.I'm happy to try a different way (enum or other) if that is preferable.
By submitting this pull request