Skip to content

Added explicit data locations for a few parameters that were missed. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axic merged 1 commit into from
Jul 9, 2018
Merged

Added explicit data locations for a few parameters that were missed. #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/mocks/BouncerMock.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ contract SignatureBouncerMock is SignatureBouncer {
return isValidSignatureAndMethod(_address, _sig);
}

function onlyWithValidSignatureAndMethod(bytes _sig)
function onlyWithValidSignatureAndMethod(bytes memory _sig)
onlyValidSignatureAndMethod(_sig)
public
view
Expand Down
2 changes: 1 addition & 1 deletion contracts/ownership/rbac/RBAC.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ contract RBAC {
* @param roleName the name of the role
* // reverts
*/
modifier onlyRole(string roleName)
modifier onlyRole(string memory roleName)
{
checkRole(msg.sender, roleName);
_;
Expand Down