Skip to content

fix(types): add handlers to AxiosInterceptorManager interface #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: v1.x
Choose a base branch
from
Open

fix(types): add handlers to AxiosInterceptorManager interface #5551

wants to merge 2 commits into from
+40 −4

Conversation

tiborpilz
Copy link

This PR adds the handlers property to the AxiosInterceptorManager interface. The missing property has been an issue in correctly setting up interceptor tests, as described in #3792

@tiborpilz tiborpilz force-pushed the add-interceptor-handler-types branch from 21edba8 to 63ab2f1 Compare February 25, 2023 14:52
@tiborpilz tiborpilz force-pushed the add-interceptor-handler-types branch from 63ab2f1 to 54354d9 Compare March 24, 2023 16:11
tiagobarros01
tiagobarros01 reviewed Apr 13, 2023
View reviewed changes
Copy link

@tiagobarros01 tiagobarros01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any predictions for progress on this PR?

@tiborpilz tiborpilz force-pushed the add-interceptor-handler-types branch from 54354d9 to 6c967e3 Compare May 23, 2023 10:45
@bugkarma
Copy link

bugkarma commented Oct 4, 2023

Ran into this issue trying to read handlers property. Will this be merged?

@faizanallex
Copy link

Waiting

@jasonsaayman
Copy link
Member

@tiborpilz is it possible for you to resolve conflicts?

@jasonsaayman jasonsaayman self-assigned this Dec 6, 2024
@jasonsaayman jasonsaayman self-requested a review December 6, 2024 10:03
@jasonsaayman jasonsaayman added the follow-up To be followed up on label Dec 6, 2024
@jasonsaayman jasonsaayman removed their request for review December 6, 2024 11:55
@jasonsaayman jasonsaayman removed their assignment Dec 6, 2024
@tiborpilz tiborpilz force-pushed the add-interceptor-handler-types branch from 6c967e3 to 6f1a291 Compare December 7, 2024 09:47
@tiborpilz
Copy link
Author

@jasonsaayman sure :)

@jasonsaayman jasonsaayman self-assigned this Dec 8, 2024
@jasonsaayman jasonsaayman self-requested a review December 8, 2024 16:49
@jasonsaayman jasonsaayman added state::in-progress and removed follow-up To be followed up on labels Dec 8, 2024
@jasonsaayman jasonsaayman added this to the v1.8.0 milestone Dec 8, 2024
@tiborpilz tiborpilz force-pushed the add-interceptor-handler-types branch from 6f1a291 to c058c41 Compare December 17, 2024 15:57
@tiborpilz tiborpilz force-pushed the add-interceptor-handler-types branch from c058c41 to 2504ccf Compare December 19, 2024 15:59
@jasonsaayman jasonsaayman removed their assignment Dec 21, 2024
@jasonsaayman jasonsaayman modified the milestones: v1.8.0, v1.9.0 Feb 21, 2025
@jasonsaayman jasonsaayman removed this from v1.9.0 Apr 25, 2025
@jasonsaayman jasonsaayman removed this from the v1.9.0 milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonsaayman jasonsaayman Awaiting requested review from jasonsaayman

3 more reviewers

@tiagobarros01 tiagobarros01 tiagobarros01 approved these changes

@ODGodinho ODGodinho ODGodinho approved these changes

@hexiaokang hexiaokang hexiaokang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
priority::medium A medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tiborpilz @bugkarma @faizanallex @jasonsaayman @ODGodinho @hexiaokang @tiagobarros01