feat: make AxiosResponse implement the fetch Response API #6185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve interoperability with tooling that wants native Fetch API Response objects, by implementing the Response interface.
In theory it's unlikely this will break runtime code.It might break types in some projects becauseheadersis now a native Headers object. EDIT: The change toheadersis a breaking change. 🤦 You can't access it with['name']syntax.I also haven't tested this thoroughly. I mainly just want to push for this and prove that it's possible. It will help legacy codebases a lot.